fix: handle missing git command when getting local version#557
Merged
Conversation
jansegre
reviewed
Apr 17, 2023
jansegre
approved these changes
Apr 17, 2023
luislhl
force-pushed
the
fix/ci-docker-build
branch
from
0c5f356 to
c01acd7
Compare
glevco
approved these changes
Apr 17, 2023
Codecov Report
@@ Coverage Diff @@
## dev #557 +/- ##
==========================================
+ Coverage 83.25% 83.26% +0.01%
==========================================
Files 212 212
Lines 18723 18723
Branches 2595 2595
==========================================
+ Hits 15588 15590 +2
+ Misses 2567 2566 -1
+ Partials 568 567 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
We shouldn't get a
FileNotFoundErrorif there is nogitcommand available when trying to run it to build the local versionAn example of such case happened in https://github.com/HathorNetwork/hathor-core/actions/runs/4721185503/jobs/8374162049